DO_NOT_MERGE test: system test node 14 and 16#851
DO_NOT_MERGE test: system test node 14 and 16#851amchiclet wants to merge 2 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
size: s
Codecov Report
@@ Coverage Diff @@
## main #851 +/- ##
=======================================
Coverage 68.87% 68.87%
=======================================
Files 7 7
Lines 1253 1253
Branches 58 58
=======================================
Hits 863 863
Misses 389 389
Partials 1 1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
amchiclet
added
the
kokoro:force-run
amchiclet
added
the
do not merge
|
LGTM; possible that Node 18 tests will fail b/c there aren't prebuilt binaries for Node 18. |
amchiclet
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
Yep, you're right. Pre-built is an issue for node 18. Scoping this PR to only include node 16. |
nolanmar511
changed the title
|
Any news on the status of this PR? Tomorrow Node v18 will become LTS and so far we haven't been able to use Profiling while I think it can be really handy to have when trying to get to the bottom of performance issues on GKE |
|
There's work being done now that is needed to support Node 18 in pprof-nodejs (which this project depends on). After that work is done, this project will then be updated to support up to Node 18. Unfortunately I don't have the capacity to continue this work and somebody else in the team will be picking it up. |
Great, glad to see, work is in progress to get support for newer versions of Node :) |
|
This was already addressed in #891 I will also add node 20 in that file now |
5 participants
No description provided.