fix: do not generate stubMethodsContent if there are no methods #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feywind
approved these changes
Jan 15, 2026
| // and create an API call method for each. | ||
| const {{ service.name.toCamelCase() }}StubMethods = | ||
| [ | ||
| {%- set stubMethodsContent %} |
Contributor
There was a problem hiding this comment.
Is the indentation on this funky? (sorry, super-nit)
| // and create an API call method for each. | ||
| const {{ service.name.toCamelCase() }}StubMethods = | ||
| [ | ||
| {%- set stubMethodsContent %} |
Collaborator
Author
There was a problem hiding this comment.
no actually! I ran the baseline test so it didn't end up changing anything currently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes this problem in this PR: https://github.com/googleapis/google-cloud-node/actions/runs/20862284893/job/59944732536
basically, the issue is that we're missing a type annotation since we're instantiating an empty array. But, we shouldn't even generate this array or iterate over it if it's going to be empty. So this code just adds a branch block to skip it.