Fix Firestore SDK not limiting results when given limit(0)#2464
Draft
liu-husong wants to merge 2 commits intogoogleapis:mainfrom
Draft
Fix Firestore SDK not limiting results when given limit(0)#2464liu-husong wants to merge 2 commits intogoogleapis:mainfrom
limit(0)#2464liu-husong wants to merge 2 commits intogoogleapis:mainfrom
Conversation
Previously, calling `.limit(0)` on a Firestore Query did not correctly serialize the zero value to the underlying wire protocol. This caused queries intended to return zero results to be sent without a limit constraint, potentially returning unintended results. This commit fixes the serialization logic so that `limit(0)` is now explicitly included in the query proto. Also adds/updates related unit tests to validate the correct handling of limit-zero queries.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
bot
added
size: s
liu-husong
changed the title
limit(0)
liu-husong
changed the title
limit(0)limit(0)
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Opening this PR to sense check if this can be worked on to get merged. This PR fixes #2461 where the Firestore SDK doesn't seem to apply the limit clause when
limit(0)is given.Impact
The change should allow the Firestore SDK to handle
limit(0)properly, i.e., returning an empty array as expected.Testing
Unit test added. But I'm not familiar with the codebase so I'm not sure if that alone is sufficient.
Additional Information
Checklist
Fixes #2461 🦕