Skip to content

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Dec 22, 2025

…ted by page_size in query_and_wait

Fixes internal issue b/433324499

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

…ted by page_size in query_and_wait

Fixes internal issue b/433324499
@tswast tswast requested a review from a team as a code owner December 22, 2025 20:49
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 22, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 22, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tswast, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the documentation for the page_size parameter in the query_and_wait method of the BigQuery client library. The update provides crucial clarity by specifying which BigQuery API calls are influenced by this parameter, ensuring users have a precise understanding of its scope and preventing potential misinterpretations regarding its effect on the BigQuery Storage Read API.

Highlights

  • Documentation Clarity: Clarified the behavior of the page_size parameter within the query_and_wait method's documentation.
  • API Scope: Explicitly stated that the page_size parameter only affects jobs.query and jobs.getQueryResults API calls, and not the BigQuery Storage Read API.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a helpful clarification to the page_size parameter's docstring in the query_and_wait method. The change correctly specifies that page_size only impacts jobs.query and jobs.getQueryResults API calls, and not downloads using the BigQuery Storage Read API. This is an accurate and valuable improvement to the documentation. The change looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants