Skip to content

Conversation

@twoodwark
Copy link
Contributor

@twoodwark twoodwark commented Apr 25, 2025

Since INFORMATION_SCHEMA.KEY_COLUMN_USAGE returns ordinal position, we can use it for compliance on pk reflection.

See https://cloud.google.com/spanner/docs/information-schema#key-column-usage

  • Tests pass
  • Appropriate changes to README are included in PR (n/a)

@google-cla
Copy link

google-cla bot commented Apr 25, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Apr 25, 2025
@twoodwark
Copy link
Contributor Author

Hi, @skuruppu / @olavloite would you mind reviewing this change? I've run the compliance tests locally and things seem to be fine so I think we should run the CI checks.

@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2025
@olavloite olavloite merged commit 16c87e4 into googleapis:main May 5, 2025
14 checks passed
@olavloite
Copy link
Contributor

@twoodwark Thanks for the contribution!

@twoodwark twoodwark deleted the pk-order-reflection branch May 9, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants