feat: support commit timestamp option #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
waltaskew
force-pushed
the
support-commit-timestamps
branch
from
3d363a1 to
70744d4
Compare
olavloite
previously approved these changes
Jun 19, 2025
Contributor
olavloite
left a comment
olavloite
left a comment
There was a problem hiding this comment.
Thanks for this contribution! LGTM
Contributor
|
@waltaskew Would you mind taking a look at why the sample test run fails? |
waltaskew
force-pushed
the
support-commit-timestamps
branch
from
1925ac8 to
7390c80
Compare
Contributor
Author
Ah, sorry, missing import in the sample. Fixed! |
Add support for columns with commit timestamps: https://cloud.google.com/spanner/docs/commit-timestamp Fixes: googleapis#695
waltaskew
force-pushed
the
support-commit-timestamps
branch
from
7390c80 to
69ea1a2
Compare
olavloite
previously approved these changes
Jun 27, 2025
olavloite
force-pushed
the
support-commit-timestamps
branch
from
66838d8 to
5211be9
Compare
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
approved these changes
Jun 27, 2025
aakashanandg
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for columns with commit timestamps:
https://cloud.google.com/spanner/docs/commit-timestamp
Fixes: #695