Skip to content

Revert "skip notification tests until b/470069573 is fixed" #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chandra-siri merged 2 commits into from
Dec 23, 2025
+0 −5
Merged

Revert "skip notification tests until b/470069573 is fixed" #1694

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d814ba
Revert "skip notification tests until b/470069573 is fixed"
chandra-siri Dec 23, 2025
fefea6c
Merge branch 'main' into bring_back_notification_tests
chandra-siri Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions tests/system/test_notification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ def notification_topic(storage_client, publisher_client, topic_path, no_mtls):
publisher_client.delete_topic(request={"topic": topic_path})


@pytest.mark.skip(reason="until b/470069573 is fixed")
def test_notification_create_minimal(
storage_client,
buckets_to_delete,
Expand All @@ -101,7 +100,6 @@ def test_notification_create_minimal(
notification.delete()


@pytest.mark.skip(reason="until b/470069573 is fixed")
def test_notification_create_explicit(
storage_client,
buckets_to_delete,
Expand Down Expand Up @@ -136,7 +134,6 @@ def test_notification_create_explicit(
notification.delete()


@pytest.mark.skip(reason="until b/470069573 is fixed")
def test_notification_create_w_user_project(
storage_client,
buckets_to_delete,
Expand Down Expand Up @@ -165,7 +162,6 @@ def test_notification_create_w_user_project(
notification.delete()


@pytest.mark.skip(reason="until b/470069573 is fixed")
def test_notification_create_wo_topic_name(
storage_client,
buckets_to_delete,
Expand Down Expand Up @@ -194,7 +190,6 @@ def test_notification_create_wo_topic_name(
notification.create()


@pytest.mark.skip(reason="until b/470069573 is fixed")
def test_bucket_get_notification(
storage_client,
buckets_to_delete,
Expand Down