This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Support override of ALLOWED_URI_SCHEMES with html4.allowedUriSchemes#2033
Open
jeffreyhardy wants to merge 1 commit intogooglearchive:masterfrom
Open
Support override of ALLOWED_URI_SCHEMES with html4.allowedUriSchemes#2033jeffreyhardy wants to merge 1 commit intogooglearchive:masterfrom
jeffreyhardy wants to merge 1 commit intogooglearchive:masterfrom
Conversation
Contributor
|
Configuration by modifying global state strikes me as a bad idea, since it would interfere between any two users of the library. To pursue this I would suggest, instead, starting with a refactoring which preserving the existing entry point functions ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This indirectly addresses Issue 1558.
That issue is about data: and javascript: not being allowed protocols for URIs. This change allows the HTML sanitizer to be configured to allow any URI protocol by using a new html4 attribute, allowedUriSchemes. This custom attribute, if defined, will be used instead of the hardcoded RegEx ALLOWED_URI_SCHEMES.
For instance, to allow both data: and javascript: URIs: