Skip to content
This repository was archived by the owner on Mar 13, 2018. It is now read-only.

Removing the condition which would return status as successful #52

Open
majidfn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removing the condition which would return status as successful #52

majidfn wants to merge 1 commit into from

Conversation

@majidfn
Copy link

@majidfn majidfn commented Dec 9, 2014

If there is no status on the call, the call should not be considered as successful.
For example when the back-end server is not responding although there was a ERR_CONNECTION_RESET but still the core-response was being fire instead of core-error. This was as the result of status being 0 and and !0 would return true for isSuccess

@majidfn
Copy link
Author

majidfn commented Dec 9, 2014

This could be a fix for the following issue as well:
Polymer/polymer#744

@majidfn majidfn mentioned this pull request Dec 9, 2014
Closed
@hawkett hawkett mentioned this pull request Sep 22, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@majidfn