Disable timeout handler #519
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It suppresses panic stacktraces: golang/go#27375
Contributor
Author
|
@csieber I don't know if the timeout handler has an important role here, should we submit this as-is or perhaps add a flag to turn it off? |
Contributor
I guess without it the tv would crash the process on panic? I would leave it for now and add a flag to disable |
Contributor
Author
I don't believe so, when we disabled this we still saw the panic being gracefully caught by the http server: (full traceback is on the chat thread) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It suppresses panic stacktraces:
golang/go#27375