[skrifa] Implement sbix dupe and flip#1631
Open
valadaptive wants to merge 1 commit intogooglefonts:mainfrom
Open
[skrifa] Implement sbix dupe and flip#1631valadaptive wants to merge 1 commit intogooglefonts:mainfrom
dupe and flip#1631valadaptive wants to merge 1 commit intogooglefonts:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1137 (
flipdoesn't seem to be a bit, but instead its own graphic type that works likedupe).The sbix
dupeandflipgraphic types reference other glyphs--the "image data" for these is actually just a 16-bit glyph ID. I chose to match FreeType here and bail after 4 indirections.I've introduced another property on
BitmapGlyphfor whether the graphic should be flipped, but I've documented that it's only set for a few sbix fonts (should I be more specific and just name Apple Color Emoji?)Not sure how to produce font data to test this.