Move Setting, Weight, Stretch, and Style types to font-types#1660
Open
nicoburns wants to merge 2 commits intogooglefonts:mainfrom
Open
Move Setting, Weight, Stretch, and Style types to font-types#1660nicoburns wants to merge 2 commits intogooglefonts:mainfrom
Setting, Weight, Stretch, and Style types to font-types#1660nicoburns wants to merge 2 commits intogooglefonts:mainfrom
Conversation
Collaborator
|
Seems reasonable at a glance, ty for sending. I will ping to see if anyone forsees problems. |
Member
|
@nicoburns do you have a concrete use case/motivation for these changes? In general we want to keep changes in font-types minimal (specifically because it uses some Put another way, would moving this API to font-types be useful to you, even if we were to never significantly add to the existing API? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once
font-typeshits 1.0, these will be super-useful as interop types for the Rust crates ecosystem.We may also wish to consider some renames:
Weight->FontWeightStyle->FontStyleStretch->FontStretch(or possiblyFontWidth- matching CSS)