Depend on bytemuck_derive rather than bytemuck with the derive feature#1667
Open
nicoburns wants to merge 1 commit intogooglefonts:mainfrom
Open
Depend on bytemuck_derive rather than bytemuck with the derive feature#1667nicoburns wants to merge 1 commit intogooglefonts:mainfrom
bytemuck_derive rather than bytemuck with the derive feature#1667nicoburns wants to merge 1 commit intogooglefonts:mainfrom
Conversation
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
force-pushed
the
direct-bytemuck-derive
branch
from
e06f288 to
b475852
Compare
Collaborator
|
Apologies, lost track of this. Are you observing a measurable difference from this? |
Member
|
Yea I have no objection to this but I'm very curious to know the mechanism by which this improves things :) |
Contributor
Author
It's measurable, but it's pretty small (< 1s)
The improvement comes from improving parallelism/pipelining in the build. |
Member
Can you elaborate? Does this somehow let us start building one of the crates earlier? If yes.... why? (to be clear, I'm really just curious to understand the mechanism here :)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small win for build paralellisation (meaning that the
bytemuckcrate doesn't need to wait forbytemuck_deriveto be compiled).