Skip to content

Conversation

@rsheeter
Copy link
Collaborator

@rsheeter rsheeter commented Mar 9, 2023

Things I learned trying to compile glyphs: I want to see more of the fields of Component.

This is a blocker for completing the merge of googlefonts/fontc#120.

@rsheeter rsheeter requested a review from cmyr March 9, 2023 22:13
@rsheeter
Copy link
Collaborator Author

Apologies for the late change but I ran a force push to rebase on a main that passes clippy

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, are you reading and writing these fields, or just reading? I tend to be judicious about exposing internals of things, and often prefer getters/setters as needed, but this is definitely a personal thing.

@rsheeter
Copy link
Collaborator Author

are you reading and writing these fields, or just reading

bbox in particular I need both. I think in general write-fonts should assume it's user might want to directly poke just about anything so providing helpful methods that do the right thing is great, but shouldn't be taken to mean we can hide direct access.

@rsheeter rsheeter merged commit b353346 into main Mar 10, 2023
@rsheeter rsheeter deleted the glyf_tweak branch March 10, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants