[fea-rs] Compile format 2 contextual lookups #1877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@anthrotype is there anything new I have to do now when making changes to ttx_diff? When do we do releases of the python package, and how does that work? |
rsheeter
reviewed
Jan 12, 2026
rsheeter
approved these changes
Jan 12, 2026
I had initially struggled to come up with an input where format 2 outperformed format 3, but of course they are out there. This also updates ttx_diff to normalize these; we were already doing this for chain contexts.
cmyr
force-pushed
the
context-format-2
branch
from
d946b5a to
27789e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had initially struggled to come up with an input where format 2 outperformed format 3, but of course they are out there.
This also updates ttx_diff to normalize these; we were already doing this for chain contexts.