Interpolate anchors when instantiating smart components #1885
+266
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smart components can have anchors that vary across their internal axis space. Previously, these anchors were dropped during instantiation. Now we interpolate anchor positions using the same variation model as shape interpolation. This fixes Murecho and other fonts that use smart components with anchors. Fixes #1884
anthrotype
force-pushed
the
smart-component-anchor-interpolation
branch
from
6310ddf to
7fa9816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smart components can have anchors that vary across their internal axis space. Previously, these anchors were dropped during instantiation. Now we interpolate anchor positions using the same variation model as shape interpolation.
This fixes Murecho and other fonts that use smart components with anchors.
Fixes #1884
Equivalent fix to @khaledhosny's googlefonts/glyphsLib#1131