allow whitelist_dnswl to check ipv6 addresses #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not treat "you are blocked" indicator from dnswl.org as whitelisted
Author
|
Added another important update: dnswl.org sends me a result of 127.0.0.255 when I run into their limit of 100.000 queries a day. So I have to filter out this special result and do not treat it as whitelisted. As I think both is important - possibly I ran into this limit because I now check all IPv6 connections, too - I did not make a separate pull request but updated this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your comment in the source file says, that dnswl.org did not support IPv6 when you wrote that code.
Times have changed and dnswl supports IPv6. And more and more Mail come to us via IPv6. So I'd like to have IPv6 lookups supported.
My change introduces the use of the python module
ipaddressthat is in the standard library and exposes the field reverse_pointer since Python 3.5. I don't know if your users depend on older python versions but calculating IPv6 manually is a pain.