Test/wpt error handling

[stroiman]

No description provided.

[coderabbitai]

Walkthrough

This PR refactors the WPT test pipeline: adds a runtime-controlled concurrency cap (MAX_CONCURRENT_TESTS); introduces WebPlatformTest and adds TotalCount and PassedCount to WptSuiteResult; reworks Run to use openWindow and processEvents helpers with layered panic recovery and enhanced logging; makes test execution concurrency-aware and adjusts per-test logging; updates test-case source signatures to accept a context.CancelCauseFunc and return channels; modifies manifest loading to surface errors via the cancel cause; and converts manifest parser functions to return and propagate errors instead of panicking.

Possibly related PRs

• Fix false positive for WPT test cases #196: Adds and populates WptSuiteResult.TotalCount and WptSuiteResult.PassedCount in the same result struct.
• refactor(wpt): Introducs a "pendingTest" type #173: Modifies test-results handling and testResults/pending-test orchestration in internal/test/wpt/main.go.
• Test/wpt arguments #179: Changes WPT manifest parsing and test-case loader interfaces/control flow for manifest/test-case loading.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No pull request description was provided by the author.	Add a description explaining the error handling improvements, why they were made, and their impact on the test suite's reliability.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Test/wpt error handling' directly describes the main change—improving error handling in the WPT test suite by replacing panics with proper error propagation.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Close response body on Do error to prevent leaks.
http.Client.Do can return a non-nil res with err; not closing res.Body can leak connections.

🩹 Proposed fix

 res, err = http.DefaultClient.Do(req)
 if err != nil {
+	if res != nil && res.Body != nil {
+		res.Body.Close()
+	}
+	res = nil
 	err = fmt.Errorf("load manifest: %w", err)
 	return
 }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	func (s manifestTestCaseSource) fetchManifest(ctx context.Context) (res *http.Response, err error) {
	var req *http.Request
	req, err = http.NewRequestWithContext(ctx, http.MethodGet, s.href, nil)
	if err != nil {
	panic(fmt.Sprintf("load manifest: create request: %v", err))
	err = fmt.Errorf("load manifest: create request: %w", err)
	return
	}
	res, err := http.DefaultClient.Do(req)
	res, err = http.DefaultClient.Do(req)
	if err != nil {
	panic(fmt.Sprintf("load manifest: %v", err))
	err = fmt.Errorf("load manifest: %w", err)
	}
	ch := make(chan TestCase)
	return
	}
	func (s manifestTestCaseSource) fetchManifest(ctx context.Context) (res *http.Response, err error) {
	var req *http.Request
	req, err = http.NewRequestWithContext(ctx, http.MethodGet, s.href, nil)
	if err != nil {
	err = fmt.Errorf("load manifest: create request: %w", err)
	return
	}
	res, err = http.DefaultClient.Do(req)
	if err != nil {
	if res != nil && res.Body != nil {
	res.Body.Close()
	}
	res = nil
	err = fmt.Errorf("load manifest: %w", err)
	}
	return
	}