Address feedback: restore comprehensive tests and update README for resolver refactoring

[Copilot]

• Add comprehensive tests to SymbolResolverTest.php for namespace support
• Update README to reflect the new resolver architecture (resolver() methods on Source classes)
• Fix SymbolSource resolver to pass namespace parameter when looking up symbols

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/CarbonPHP/carbon-doctrine-types/zipball/18ba5ddfec8976260ead6e866180bd5d2f71aa1d
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/CarbonPHP/carbon/zipball/8e3643dcd149ae0fe1d2ff4f2c8e4bbfad7c165f
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/OndraM/ci-detector/zipball/8b0223b5ed235fd377c75fdd1bfcad05c0f168b8
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/azjezz/psl/zipball/15153a64c9824335ce11654522e7d88de762d39e
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/brick/math/zipball/fc7ed316430118cc7836bf45faff18d5dfc8de04
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/colinodell/json5/zipball/5724d21bc5c910c2560af1b8915f0cc0163579c8
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/composer/pcre/zipball/b2bed4734f0cc156ee1fe9c0da2550420d99a21e
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/composer/xdebug-handler/zipball/6c1925561632e83d60a44492e0b344cf48ab85ef
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/doctrine/inflector/zipball/6d6c96277ea252fc1304627204c3d5e6e15faa3b
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/gosuperscript/monads-php/zipball/2e455a22ab87ce6ce247ff709957f0abba6b222b
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/illuminate/collections/zipball/deb291b109b6f7fd776a3550a120771137b3c5d1
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/illuminate/conditionable/zipball/ec677967c1f2faf90b8428919124d2184a4c9b49
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/illuminate/container/zipball/d6eaa8afd48dbe16b6b3c412a87479cad67eeb12
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/illuminate/contracts/zipball/5ab717c8f0dd4e84be703796bbb415ccff8de57a
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/illuminate/macroable/zipball/e862e5648ee34004fa56046b746f490dfa86c613
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/illuminate/support/zipball/008b6c0d45f548de0f801d60a5854a7f9e4dd32f
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/infection/abstract-testframework-adapter/zipball/18925e20d15d1a5995bb85c9dc09e8751e1e069b
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/infection/extension-installer/zipball/9b351d2910b9a23ab4815542e93d541e0ca0cdcf
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/infection/include-interceptor/zipball/0cc76d95a79d9832d74e74492b0a30139904bdf7
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/infection/infection/zipball/feea2a48a8aeedd3a4d2105167b41a46f0e568a3
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/infection/mutator/zipball/3c976d721b02b32f851ee4e15d553ef1e9186d1d
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/jsonrainbow/json-schema/zipball/fd8e5c6b1badb998844ad34ce0abcd71a0aeb396
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/laravel/pint/zipball/5016e263f95d97670d71b9a987bd8996ade6d8d9
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/marc-mabe/php-enum/zipball/bb426fcdd65c60fb3638ef741e8782508fda7eef
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/myclabs/DeepCopy/zipball/07d290f0c47959fd5eed98c95ee5602db07e0b6a
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/nikic/PHP-Parser/zipball/3a454ca033b9e06b63282ce19562e892747449bb
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/phar-io/version/zipball/4f7fd7836c6f332bb2933569e566a0d6c4cbed74
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/php-fig/clock/zipball/e41a24703d4560fd0acb709162f73b8adfc3aa0d
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/php-fig/container/zipball/c71ecc56dfe541dbd90c5360474fbc405f8d5963
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/php-fig/log/zipball/f16e1d5863e37f8d8c2a01719f5b34baa2b714d3
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/php-fig/simple-cache/zipball/764e0b3939f5ca87cb904f570ef9be2d78a07865
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/revoltphp/event-loop/zipball/09bf1bf7f7f574453efe43044b06fafe12216eb3
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/sanmai/later/zipball/72a82d783864bca90412d8a26c1878f8981fee97
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/sanmai/pipeline/zipball/fb8d0c23b4ef085315a36d397fafa052203020ce
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/sebastianbergmann/diff/zipball/7ab1ea946c012266ca32390913653d844ecd085f
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/clock/zipball/b81435fbd6648ea425d1ee96a2d8e68f4ceacd24
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/console/zipball/c28ad91448f86c5f6d9d2c70f0cf68bf135f252a
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/deprecation-contracts/zipball/63afe740e99a13ba87ec199bb07bbdee937a5b62
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/filesystem/zipball/e9bcfd7837928ab656276fe00464092cc9e1826a
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/finder/zipball/9f696d2f1e340484b4683f7853b273abff94421f
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/polyfill-ctype/zipball/a3cc8b044a6ea513310cbd48ef7333b384945638
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/polyfill-intl-grapheme/zipball/380872130d3a5dd3ace2f4010d95125fde5d5c70
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/polyfill-intl-normalizer/zipball/3833d7255cc303546435cb650316bff708a1c75c
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/polyfill-mbstring/zipball/6d857f4d76bd4b343eac26d6b539585d2bc56493
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/yqxXm3 /usr/bin/composer install (http block)
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/polyfill-php83/zipball/17f6f9a6b1735c0f163024d959f700cfbc5155e5
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/polyfill-php84/zipball/d8ced4d875142b6a7426000426b8abc631d6b191
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/polyfill-php85/zipball/d4e5fcd4ab3d998ab16c0db48e6cbb9a01993f91
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/yqxXm3 /usr/bin/composer install (http block)
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/process/zipball/f24f8f316367b30810810d4eb30c543d7003ff3b
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/service-contracts/zipball/45112560a3ba2d715666a509a0bc9521d10b6c43
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/string/zipball/f96476035142921000338bad71e5247fbc138872
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/translation-contracts/zipball/65a8bc82080447fae78373aa10f8d13b38338977
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/symfony/translation/zipball/ec25870502d0c7072d086e8ffba1420c85965174
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/thecodingmachine/safe/zipball/2cdd579eeaa2e78e51c7509b50cc9fb89a956236
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/theofidry/cpu-core-counter/zipball/db9508f7b1474469d9d3c53b86f817e344732678
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/voku/portable-ascii/zipball/b1d923f88091c6bf09699efcd7c8a1b1bfd7351d
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)
• https://api.github.com/repos/webmozarts/assert/zipball/9be6926d8b485f55b9229203f962b51ed377ba68
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/vdcep3 /usr/bin/composer install --ignore-platform-reqs --no-interaction (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[robertvansteen]

@copilot please fix the failing tests

[Copilot]

@copilot please fix the failing tests

Fixed in commit d4af9dc. The issue was that SymbolSource::resolver() wasn't passing the $this->namespace parameter to $registry->get(), causing namespaced symbols to fail lookup. All 186 tests now pass.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• schema.phpunit.de
  • Triggering command: php vendor/bin/infection --threads=max --show-mutations (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)