Skip to content

Lcu manpage and makefile#5

Open
mojadita wants to merge 5 commits intomasterfrom
lcu_manpage_and_makefile
Open

Lcu manpage and makefile#5
mojadita wants to merge 5 commits intomasterfrom
lcu_manpage_and_makefile

Conversation

@mojadita
Copy link
Collaborator

@mojadita mojadita commented Jan 29, 2023

Hi, I have added a manpage to zmac, based on the documentation you generate with the doc program. I have also tweaked the Makerile to create/install the man pages and install them with $(prefix) based directories.

I expect you will accept my pull request, as I plan to use it (and propose this new version) to be used as a submodule in xtrs project. This will allow us to have a precise version of zmac in xtrs, so we don't need to tweak Makefile in order to compile xtrs. That project claims to use an old version of zmac (one that has a different command line options).

Thanks in advance,

Luis.

Signed-off-by: Luis Colorado <luiscoloradourcola@gmail.com>
* Still to correct the looong z80 mnemonics table, that fails to
  format with mdoc package because .TS H seems to be unsupported,
  and doesn't fit in a single page.

Signed-off-by: Luis Colorado <luiscoloradourcola@gmail.com>
Signed-off-by: Luis Colorado <luiscoloradourcola@gmail.com>
Signed-off-by: Luis Colorado <luiscoloradourcola@gmail.com>
Signed-off-by: Luis Colorado <luiscoloradourcola@gmail.com>
@gp48k
Copy link
Owner

gp48k commented Apr 2, 2023

Sorry about the delay; I hadn't noticed the pull requests until just recently.

I'd want the manual page to be generated from the source documentation rather than something I'd need to maintain separately. I'll work on extending doc.c to handle that.

I'd rather the changes to the makefile be more minimal. Just to keep it as simple as possible.

@gp48k
Copy link
Owner

gp48k commented Apr 2, 2023

Oh, forgot to thank you for the manual page. It'll be a big help in showing what doc.c needs to do. I wrote manual pages long, long ago but am not up to date on the latest things.

@mojadita
Copy link
Collaborator Author

mojadita commented Apr 9, 2023 via email

@gp48k
Copy link
Owner

gp48k commented Apr 9, 2023

My idea was to work it out together to accept your PR.

I've committed changes to have "doc.c" generate the manual page. There is room for improvement but I think it is a good starting point.

I'm not really familiar with git or github workflow. All we really need now is to get the Makefile updated so it can optionally install the manual page. I don't know if it makes more sense for you to update your PR which the Makefile changes or to simply make a new PR with the Makefile changes.

Take your pick; either is fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants