Update to respect parent scope for BUILD_SHARED_LIBS cmake variable#83
Merged
natevm merged 1 commit intogprt-org:masterfrom Oct 10, 2025
Merged
Conversation
13 tasks
natevm
approved these changes
Oct 10, 2025
Contributor
natevm
left a comment
natevm
left a comment
There was a problem hiding this comment.
Should be okay since this defaults to no change unless an option is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enforces that CMake should respect the parent scope for the CMake variable
BUILD_SHARED_LIBSif GPRT is included as a subproject but otherwise can default to the same behaviour it had before if the parent project does not provide a value for this.Before these changes the line
set(BUILD_SHARED_LIBS ${GPRT_BUILD_SHARED})would always setBUILD_SHARED_LIBSto matchGPRT_BUILD_SHAREDno matter what the parent project was trying to do. So for example, if you wanted to build GPRT as a shared library but keep its dependency libraries static it would be impossible to do so.