Fix a race condition with DataChannel#421
Open
gtherond wants to merge 4 commits intogradio-app:mainfrom
Open
Conversation
Fix a race condition where sending data on DC fail as it doesn't check for the readyState to be opened before sending data onto the DC.
freddyaboulton
approved these changes
Jan 12, 2026
Collaborator
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
Thanks @gtherond !
Collaborator
|
Can you please fix the lint? Looks like the indentation does not line up |
Author
For sure! |
Fix an issue with the amount of spaces on indent.
Author
|
Ok, I've added the missing part of the patch, sorry it seems I didn't performed my diff patch properly the first time ^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a race condition where sending data on DC fail as it doesn't check for the readyState to be opened before sending data onto the DC.