-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[enterprise-logs] Mark chart as deprecated #3984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
|
The chart never works, the minio version seems never exists, |
|
@zalegrala I may need your assistance here, because the chart is broken anyways (due invalid dependencies), I cant merge this. |
|
Hmm, I can't force-merge this either with the failing CI. So to deprecate it, do we need to fix the dependencies here? |
|
@jkroepke what if we remove the minio dependency completely or set the version to something that actually exists ? anyways the chart is being deprecated so I don't really think it matters ? |
|
@jkroepke the tempo-distributed chart also includes minio (the version that actually exists) as one of its dependency, how about if could you try with the same version here in order to pass CI check: helm-charts/charts/tempo-distributed/Chart.yaml Lines 27 to 32 in 0db5800
|
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
cbe0ff3 to
d0e21ff
Compare
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
No description provided.