-
Notifications
You must be signed in to change notification settings - Fork 38
Fix workflow references #2261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix workflow references #2261
Conversation
References were broken in 8bb6339 Fixes: grafana#2260
|
|
|
@StephenKing thanks for catching this, we are going to review shorty! |
jackw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Apologies for the breakage and thanks so much for fixing this @StephenKing. 🏅
As the workflows aren't happy with forks (we need to fix this) I've tested locally and pushed a scaffold using the changes in this branch to https://github.com/jackw/workflow-test-plugin which passes CI. 🟢
|
🚀 PR was released in |
|
Thanks for the quick fix! I'd appreciate, if you could continue here, which was the next problem I ran into while creating a plugin: grafana/plugin-actions#177 |
What this PR does / why we need it:
References to Github workflows were broken in 8bb6339
Which issue(s) this PR fixes:
Fixes: #2260