Skip to content

Conversation

@grahamschock
Copy link
Owner

Summary of this Pull Request (PR)

Add description here.

Intent for your PR

Choose one (Mandatory):

  • This PR is for a code-review and is intended to get feedback, but not to be pulled yet.
  • This PR is mature, and ready to be integrated into the repo.

Reviewers (Mandatory):

(Specify @<github.com username(s)> of the reviewers. Ex: @user1, @user2)

Code Quality

As part of this pull request, I've considered the following:

Style:

  • Comments adhere to the Style Guide (SG)
  • Spacing adhere's to the SG
  • Naming adhere's to the SG
  • All other aspects of the SG are adhered to, or exceptions are justified in this pull request
  • I have run the auto formatter on my code before submitting this PR (see doc/auto_formatter.md for instructions)

Code Craftsmanship:

  • I've made an attempt to remove all redundant code
  • I've considered ways in which my changes might impact existing code, and cleaned it up
  • I've formatted the code in an effort to make it easier to read (proper error handling, function use, etc...)
  • I've commented appropriately where code is tricky
  • I agree that there is no "throw-away" code, and that code in this PR is of high quality

Testing

I've tested the code using the following test programs (provide list here):

  • micro_booter
  • unit_pingpong
  • unit_schedtests
  • ...(add others here)

gparmer and others added 30 commits February 28, 2020 18:28
- blockpoints added, along with a simple lock on top
- added blkpts to sl to support the blkpt library
- added a stacklist for stack-allocated block-tracking structures
Note that this is currently NOT multi-core safe as it relies on the sl
critical section. Will need to change the stacklist to track trebor
stacks of threads to work for multi-core.
…acking

- Simply used a Treiber Stack (CAS-driven stack) that doesn't have ABA
  problems given the blocking behavior of threads.
- Remaining problem: we don't use `sl`'s support to wake threads
  across cores.
- Asynchronous by default, and blocking on boundary conditions (queue full/empty)
- Macros to inline most of the channel logic and enable the magic of constant propagation
- Simple implementation for a single producer, single consumer
@grahamschock
Copy link
Owner Author

/AzurePipelines run

1 similar comment
@grahamschock
Copy link
Owner Author

/AzurePipelines run

@grahamschock grahamschock reopened this May 16, 2020
@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@grahamschock
Copy link
Owner Author

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@grahamschock
Copy link
Owner Author

/AzurePipelines help

@azure-pipelines
Copy link

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@grahamschock grahamschock linked an issue May 4, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Issue

3 participants