-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Begin rewriting tests #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
spotandjake
wants to merge
16
commits into
grain-lang:main
Choose a base branch
from
spotandjake:spotandjake-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,636
−566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee8c133 to
60b313d
Compare
fea21c0 to
c5ae894
Compare
spotandjake
added a commit
to spotandjake/binaryen.ml
that referenced
this pull request
Dec 13, 2025
While working on grain-lang#265 I noticed that I was getting errors on `caml_binaryen_add_custom_section` as `caml_array_of_string` was deprecated for `caml_uint8_array_of_string` this updates that. The reason this doesn't appear for us is because of our test suite never calls this function.
ospencer
pushed a commit
that referenced
this pull request
Dec 21, 2025
While working on #265 I noticed that I was getting errors on `caml_binaryen_add_custom_section` as `caml_array_of_string` was deprecated for `caml_uint8_array_of_string` this updates that. The reason this doesn't appear for us is because of our test suite never calls this function.
11797fb to
81bba2b
Compare
81bba2b to
2091fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft as I'm not sure we are going to want to merge this work, and I'm not finished writing the implementation.
I noticed that we are not testing a bunch of the binaryen api, and while we do not care too much about testing behaviour as binaryen does that downstream, we probably want to be calling every function to ensure that our api is correct.
This is an effort to rewrite our test suite to cover every function.
Notes:
Closes: #244