Conversation
sanand0
left a comment
sanand0
left a comment
There was a problem hiding this comment.
See https://learn.gramener.com/guide/contributing/#test-gramex on how to run test cases.
Please add test cases in tests/test_pptxhandler.py. Add a function under TestPPTXHandler called test_png and test_pdf. Just verify that it creates a non-empty PDF and PNG in the correct directory for now.
| prs.save(target) | ||
| file_name, file_ext = os.path.splitext(target) | ||
| pres_name = f'{file_name}.pptx' | ||
| prs.save(pres_name) |
There was a problem hiding this comment.
This should be prs.save(target) -- what if target has a .PPTX in caps? Just retain the original.
Instead, just extract the file_ext -- convert it to lowercase.
| prs.save(pres_name) | ||
|
|
||
| # if output is a pdf, use soffice to convert pptx to pdf, remove pptx file | ||
| if file_ext in ['.pdf', '.png'] and pres_name: |
There was a problem hiding this comment.
I prefer if file_ext in {'.pdf', '.png'} -- i.e. set is faster than list to search in.
Nest this under if target:. You don't need to run this code unless target is specified. Then you don't need to check for pres_name
| # if output is a pdf, use soffice to convert pptx to pdf, remove pptx file | ||
| if file_ext in ['.pdf', '.png'] and pres_name: | ||
| abs_path = os.path.split(os.path.abspath(target))[0] | ||
| subprocess.call(['soffice', '--headless', '--convert-to', 'pdf', f'{pres_name}', |
There was a problem hiding this comment.
Use subprocess.run instead.
|
|
||
| # if output is a pdf, use soffice to convert pptx to pdf, remove pptx file | ||
| if file_ext in ['.pdf', '.png'] and pres_name: | ||
| abs_path = os.path.split(os.path.abspath(target))[0] |
There was a problem hiding this comment.
Check if soffice is in the path using shutilwhich.which('soffice')
If it's not there, use app_log.error() to report an error.
| os.remove(pres_name) | ||
|
|
||
| # if output is a png, use the image magick with pdf generated in previous step to convert to png, remove pdf file | ||
| if file_ext == '.png' and pdf_name: |
There was a problem hiding this comment.
pdf_name will not be required.
|
|
||
| # if output is a png, use the image magick with pdf generated in previous step to convert to png, remove pdf file | ||
| if file_ext == '.png' and pdf_name: | ||
| subprocess.call(['magick', 'convert', f'{pdf_name}', f'{file_name}-%d.png']) |
There was a problem hiding this comment.
Check using shutilwhich.which. Use subprocess.run
2 participants
Added in code for ppt-pdf/png using subprocess by splitting the extension from target value.
Attaching the link for example usage: python, pptx file.
Screenshots if LibreOffice, ImageMagick (pre requisites) if not installed.