Skip to content

feat: completed zisk bls12_381 patches#6

Merged
ArtiomTr merged 1 commit intograndinetech:zkcrypto/bls12_381-6bb9695from
jimmychu0807:jc/zkvm-zisk-bls12_381
Dec 18, 2025
Merged

feat: completed zisk bls12_381 patches#6
ArtiomTr merged 1 commit intograndinetech:zkcrypto/bls12_381-6bb9695from
jimmychu0807:jc/zkvm-zisk-bls12_381

Conversation

@jimmychu0807
Copy link

No description provided.

Copy link
Collaborator

@ArtiomTr ArtiomTr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small moment: when you add precompile block to previous ones, e.g.:

// RISC0
#[cfg(all(target_os = "zkvm", target_vendor = "risc0"))]
{ /* ... */ }

#[cfg(all(target_os = "zkvm", target_vendor = "zisk"))]
{ /* your code */ }

// SP1
#[cfg(all(target_os = "zkvm", target_vendor = "sp1"))]
{ /* ... */ }

can you please move your patch to the bottom, and include comment:

// RISC0
#[cfg(all(target_os = "zkvm", target_vendor = "risc0"))]
{ /* ... */ }

- #[cfg(all(target_os = "zkvm", target_vendor = "zisk"))]
- { /* your code */ }

// SP1
#[cfg(all(target_os = "zkvm", target_vendor = "sp1"))]
{ /* ... */ }

+ // Zisk
+ #[cfg(all(target_os = "zkvm", target_vendor = "zisk"))]
+ { /* your code */ }

thank you 🙏

@jimmychu0807
Copy link
Author

@ArtiomTr updated based on the comments above.

Copy link
Collaborator

@ArtiomTr ArtiomTr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Please squash all your commits into one, and make commit message like others:

Add support for zisk precompiles

Also, please don't forget to include original precompile authors as co-authors: here is docs how to do that. Thank you!

@jimmychu0807 jimmychu0807 force-pushed the jc/zkvm-zisk-bls12_381 branch from ba80fdc to 2e9ef3a Compare December 18, 2025 10:10
Co-authored-by: agnusmor <agnusmor@gmail.com>
Co-authored-by: Héctor Masip Ardevol <68732820+hecmas@users.noreply.github.com>
Co-authored-by: Artiom Tretjakovas <hi@sirse.dev>
@jimmychu0807 jimmychu0807 force-pushed the jc/zkvm-zisk-bls12_381 branch from 2e9ef3a to eaaffcb Compare December 18, 2025 10:23
@jimmychu0807
Copy link
Author

@ArtiomTr commits squashed with updated comment and co-authors attributed.

@ArtiomTr ArtiomTr merged commit ae7f857 into grandinetech:zkcrypto/bls12_381-6bb9695 Dec 18, 2025
12 of 13 checks passed
@jimmychu0807 jimmychu0807 deleted the jc/zkvm-zisk-bls12_381 branch December 18, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants