feat: completed zisk bls12_381 patches#6
Merged
ArtiomTr merged 1 commit intograndinetech:zkcrypto/bls12_381-6bb9695from Dec 18, 2025
Merged
Conversation
ArtiomTr
requested changes
Dec 9, 2025
Collaborator
ArtiomTr
left a comment
There was a problem hiding this comment.
one small moment: when you add precompile block to previous ones, e.g.:
// RISC0
#[cfg(all(target_os = "zkvm", target_vendor = "risc0"))]
{ /* ... */ }
#[cfg(all(target_os = "zkvm", target_vendor = "zisk"))]
{ /* your code */ }
// SP1
#[cfg(all(target_os = "zkvm", target_vendor = "sp1"))]
{ /* ... */ }can you please move your patch to the bottom, and include comment:
// RISC0
#[cfg(all(target_os = "zkvm", target_vendor = "risc0"))]
{ /* ... */ }
- #[cfg(all(target_os = "zkvm", target_vendor = "zisk"))]
- { /* your code */ }
// SP1
#[cfg(all(target_os = "zkvm", target_vendor = "sp1"))]
{ /* ... */ }
+ // Zisk
+ #[cfg(all(target_os = "zkvm", target_vendor = "zisk"))]
+ { /* your code */ }thank you 🙏
Author
|
@ArtiomTr updated based on the comments above. |
ArtiomTr
approved these changes
Dec 18, 2025
Collaborator
ArtiomTr
left a comment
There was a problem hiding this comment.
Perfect! Please squash all your commits into one, and make commit message like others:
Add support for zisk precompiles
Also, please don't forget to include original precompile authors as co-authors: here is docs how to do that. Thank you!
ba80fdc to
2e9ef3a
Compare
Co-authored-by: agnusmor <agnusmor@gmail.com> Co-authored-by: Héctor Masip Ardevol <68732820+hecmas@users.noreply.github.com> Co-authored-by: Artiom Tretjakovas <hi@sirse.dev>
2e9ef3a to
eaaffcb
Compare
Author
|
@ArtiomTr commits squashed with updated comment and co-authors attributed. |
ae7f857
into
grandinetech:zkcrypto/bls12_381-6bb9695
12 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.