Main #98
Main #98
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // Convert reasoning_budget_tokens (u32) to thinking_budget (i32) | ||
| // -1 means dynamic thinking, 0 means off (for supported models) | ||
| let thinking_budget = self.reasoning_budget_tokens.map(|b| b as i32); |
There was a problem hiding this comment.
The builder converts reasoning_budget_tokens from u32 to i32, but the comment immediately below says -1 enables dynamic thinking. Because the public API only accepts u32, callers cannot provide -1, so dynamic thinking can’t actually be enabled even though it’s documented as supported. This will surprise users following the new example/docs and silently block the intended behavior; consider accepting i32 (or adding a separate flag) so -1 can be passed through.
Useful? React with 👍 / 👎.
| json_schema: Option<StructuredOutputFormat>, | ||
| tools: Option<Vec<Tool>>, | ||
| thinking_budget: Option<i32>, | ||
| thinking_level: Option<String>, | ||
| include_thoughts: Option<bool>, |
There was a problem hiding this comment.
The Google::new signature now requires thinking_budget, thinking_level, and include_thoughts, but the module-level example at the top of google.rs still calls it with the old 10-argument form. cargo test runs doctests by default, so the example will now fail to compile. Please update the doc example (or switch it to LLMBuilder) to match the new signature.
Useful? React with 👍 / 👎.
1 participant
Fxes #97