Fix lost thread and fiber locals #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thread and fiber locals are being cleared on completion of every future. If the promise ran on the same thread as the request, or the same thread as the last promise, the locals are then not available. The execution context hasn't changed in those circumstances so the code that sets the locals at the start of a promise doesn't run. 1. Thread 1 runs 2. Sets context 3. Loads scope 4. Clears context 5. Thread 1 runs next scope 6. Context hasn’t changed so doesn’t set it again 7. Loads scope 8. Fails because the code relying on the context causes an exception because the locals aren't available. Instead always set the thread and fiber locals and only clear those that we know are new. This should avoid the lost locals and also avoid memory leaks between promises. See: graphiti-api#496
Collaborator
|
Thanks @MattFenelon! This looks/works great |
github-actions bot
pushed a commit
that referenced
this pull request
May 20, 2025
## [1.8.2](v1.8.1...v1.8.2) (2025-05-20) ### Bug Fixes * prevent context loss by always setting thread and fiber locals ([#497](#497)) ([5f45f76](5f45f76))
|
🎉 This PR is included in version 1.8.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Contributor
Author
|
Good to hear! Thanks for the merge, @jkeen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread and fiber locals are being cleared on completion of every future. If the promise ran on the same thread as the request, or the same thread as the last promise, the locals are then not available. The execution context hasn't changed in those circumstances so the code that sets the locals at the start of a promise doesn't run.
Instead always set the thread and fiber locals and only clear those that we know are new. This should avoid the lost locals and also avoid memory leaks between promises.
See: #496