Skip to content

Conversation

@bguban
Copy link
Contributor

@bguban bguban commented Dec 30, 2025

Looke like rails 8.1 removed ActionDispatch::Journey::Router::Utils.uri_decoder method and now the default way to decode the url is to use URI.decode_uri_component

…ri_decoder method and now the default way to decode the url is to use URI.decode_uri_component
@jkeen
Copy link
Collaborator

jkeen commented Jan 2, 2026

@bguban Thanks for the PR—looks like there are a bunch of failing tests?

@bguban
Copy link
Contributor Author

bguban commented Jan 2, 2026

@jkeen, yeah, but looks like they are not related to my changes. I created a different PR where I changed only README.md #501 and it also has a bunch of failed tests.

@bguban
Copy link
Contributor Author

bguban commented Jan 2, 2026

I added tests for rails 8.1 just to be sure that nothing else is broken

@jkeen
Copy link
Collaborator

jkeen commented Jan 2, 2026

Thanks for adding the readme change test, that clarifies some things. The 8.x failures make sense on the readme test, and there's a single 7.x failure that seems to have appeared since last release due to an upstream change I'm guessing, but this change for rails 8 seems to cause a bunch of failures in the 5, 6, and 7 appraisals that all seem to be related to that url_decoder thing that are not present in the readme test 🤔

@bguban
Copy link
Contributor Author

bguban commented Jan 3, 2026

Oh, my bad, I accidentally checked for the wrong method. Looks like everything is good now.

@jkeen jkeen merged commit 34d0cf0 into graphiti-api:main Jan 3, 2026
51 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 3, 2026
# [1.9.0](v1.8.2...v1.9.0) (2026-01-03)

### Features

* Support rails 8.1 ([#500](#500)) ([34d0cf0](34d0cf0))
@github-actions
Copy link

github-actions bot commented Jan 3, 2026

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants