-
Notifications
You must be signed in to change notification settings - Fork 125
replace theme switcher feature flag with local storage value #7548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace theme switcher feature flag with local storage value #7548
Conversation
Summary of ChangesHello @jonathanawesome, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the theme switcher activation mechanism, moving away from a feature flag driven by environment variables to a local storage-based approach. This change aims to provide greater flexibility for testing the ThemeSwitcher UI, particularly in production environments, by allowing users to enable it directly through their browser's developer console. The update involves modifying the theme provider to check local storage for activation and cleaning up the associated environment variable configurations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7548.hive-storybook.pages.dev |
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/apollo |
0.47.2-alpha-20260123193116-80c82f7dd5586e5280f7804fbfba97ba4b1bf86e |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/cli |
0.57.4-alpha-20260123193116-80c82f7dd5586e5280f7804fbfba97ba4b1bf86e |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/core |
0.20.2-alpha-20260123193116-80c82f7dd5586e5280f7804fbfba97ba4b1bf86e |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/envelop |
0.40.4-alpha-20260123193116-80c82f7dd5586e5280f7804fbfba97ba4b1bf86e |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/yoga |
0.47.2-alpha-20260123193116-80c82f7dd5586e5280f7804fbfba97ba4b1bf86e |
npm ↗︎ unpkg ↗︎ |
hive |
9.2.0-alpha-20260123193116-80c82f7dd5586e5280f7804fbfba97ba4b1bf86e |
npm ↗︎ unpkg ↗︎ |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR replaces the feature flag for the theme switcher with a local storage value. The implementation correctly removes the environment variable-based feature flag. However, the new implementation using localStorage.getItem directly within components is not reactive. The UI will not update when the local storage value is changed in the browser console, which seems to be the main goal. I've provided suggestions to convert the check into a reactive custom hook (useIsThemeSwitcherEnabled) to ensure the UI updates as expected.
💻 Website PreviewThe latest changes are available as preview in: https://pr-7548.hive-landing-page.pages.dev |
|
|
||
| const STORAGE_KEY = 'hive-theme'; | ||
| const isThemeSwitcherEnabled = env.featureFlags.themeSwitcher; | ||
| const TEMP_THEME_SWITCHER_KEY = 'hive-temp-theme-switcher'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the goal is to introduce more of these it might make sense to prefix them with feature-flag-?
Description
This PR replaces the feature flag-driven ThemeSwitcher UI with a value from local storage. This will allow users in prod to test the UI.
Once this PR is merged, running
localStorage.setItem('hive-temp-theme-switcher', 'true')in the browser console will trigger the UI.Additionally, this PR forces dark mode regardless of OS setting and cleans up the
dark:classes we had around the codebase.