Skip to content

Conversation

@jonathanawesome
Copy link
Member

@jonathanawesome jonathanawesome commented Jan 23, 2026

Description

This PR replaces the feature flag-driven ThemeSwitcher UI with a value from local storage. This will allow users in prod to test the UI.

Once this PR is merged, running localStorage.setItem('hive-temp-theme-switcher', 'true') in the browser console will trigger the UI.

Additionally, this PR forces dark mode regardless of OS setting and cleans up the dark: classes we had around the codebase.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jonathanawesome, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the theme switcher activation mechanism, moving away from a feature flag driven by environment variables to a local storage-based approach. This change aims to provide greater flexibility for testing the ThemeSwitcher UI, particularly in production environments, by allowing users to enable it directly through their browser's developer console. The update involves modifying the theme provider to check local storage for activation and cleaning up the associated environment variable configurations.

Highlights

  • Feature Flag Removal: The theme switcher's activation mechanism has been decoupled from environment-based feature flags, simplifying its deployment and testing.
  • Local Storage Activation: The theme switcher is now enabled by setting a specific key in the browser's local storage, allowing for on-demand activation in any environment.
  • Configuration Cleanup: Related environment variable definitions and their parsing logic have been removed, streamlining the frontend configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7548.hive-storybook.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/apollo 0.47.2-alpha-20260123193116-80c82f7dd5586e5280f7804fbfba97ba4b1bf86e npm ↗︎ unpkg ↗︎
@graphql-hive/cli 0.57.4-alpha-20260123193116-80c82f7dd5586e5280f7804fbfba97ba4b1bf86e npm ↗︎ unpkg ↗︎
@graphql-hive/core 0.20.2-alpha-20260123193116-80c82f7dd5586e5280f7804fbfba97ba4b1bf86e npm ↗︎ unpkg ↗︎
@graphql-hive/envelop 0.40.4-alpha-20260123193116-80c82f7dd5586e5280f7804fbfba97ba4b1bf86e npm ↗︎ unpkg ↗︎
@graphql-hive/yoga 0.47.2-alpha-20260123193116-80c82f7dd5586e5280f7804fbfba97ba4b1bf86e npm ↗︎ unpkg ↗︎
hive 9.2.0-alpha-20260123193116-80c82f7dd5586e5280f7804fbfba97ba4b1bf86e npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 80c82f7dd5586e5280f7804fbfba97ba4b1bf86e

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR replaces the feature flag for the theme switcher with a local storage value. The implementation correctly removes the environment variable-based feature flag. However, the new implementation using localStorage.getItem directly within components is not reactive. The UI will not update when the local storage value is changed in the browser console, which seems to be the main goal. I've provided suggestions to convert the check into a reactive custom hook (useIsThemeSwitcherEnabled) to ensure the UI updates as expected.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

💻 Website Preview

The latest changes are available as preview in: https://pr-7548.hive-landing-page.pages.dev

@jonathanawesome jonathanawesome marked this pull request as draft January 23, 2026 14:34

const STORAGE_KEY = 'hive-theme';
const isThemeSwitcherEnabled = env.featureFlags.themeSwitcher;
const TEMP_THEME_SWITCHER_KEY = 'hive-temp-theme-switcher';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the goal is to introduce more of these it might make sense to prefix them with feature-flag-?

@n1ru4l n1ru4l merged commit 305477f into main Jan 27, 2026
50 of 51 checks passed
@n1ru4l n1ru4l deleted the swap-theme-switcher-feature-flag-to-local-storage branch January 27, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants