-
Notifications
You must be signed in to change notification settings - Fork 125
Render directive diff on schema definitions #7552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jdolle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the schema proposal feature by enabling the visualization of directive changes directly on schema definitions. It achieves this by updating core GraphQL inspection libraries, streamlining the data models for schema change types, and integrating the directive diffing functionality into the schema rendering process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7552.hive-storybook.pages.dev |
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/apollo |
0.47.2-alpha-20260126175606-84de5d223e3dd1d5f42b8b442215cceadead1007 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/cli |
0.57.4-alpha-20260126175606-84de5d223e3dd1d5f42b8b442215cceadead1007 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/core |
0.20.2-alpha-20260126175606-84de5d223e3dd1d5f42b8b442215cceadead1007 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/envelop |
0.40.4-alpha-20260126175606-84de5d223e3dd1d5f42b8b442215cceadead1007 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/yoga |
0.47.2-alpha-20260126175606-84de5d223e3dd1d5f42b8b442215cceadead1007 |
npm ↗︎ unpkg ↗︎ |
hive |
9.2.0-alpha-20260126175606-84de5d223e3dd1d5f42b8b442215cceadead1007 |
npm ↗︎ unpkg ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates @graphql-inspector dependencies to an alpha version to support rendering directive diffs on schema definitions. The implementation correctly adds directive diffing for the root schema, but uses an incorrect path for schema-level directives. Additionally, several GraphQL types and Zod models are cleaned up by removing an unused schemaTypeName field. While the use of alpha dependencies is necessary for the new functionality, it introduces a potential stability risk that should be mitigated by upgrading to a stable release when available.
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7552.hive-landing-page.pages.dev |
Background
https://linear.app/the-guild/issue/CONSOLE-1545/schema-proposals-support-extend-in-schemas
Description