Skip to content

Conversation

@jdolle
Copy link
Collaborator

@jdolle jdolle commented Jan 24, 2026

Background

https://linear.app/the-guild/issue/CONSOLE-1545/schema-proposals-support-extend-in-schemas

Description

  • Removes unused schema change fields from schema.
  • Updates graphql-inspector packages
  • Adds diffDirective call to root schema definition

@jdolle jdolle requested a review from n1ru4l January 24, 2026 00:35
@jdolle jdolle self-assigned this Jan 24, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jdolle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the schema proposal feature by enabling the visualization of directive changes directly on schema definitions. It achieves this by updating core GraphQL inspection libraries, streamlining the data models for schema change types, and integrating the directive diffing functionality into the schema rendering process.

Highlights

  • Dependency Updates: Updated @graphql-inspector/core and @graphql-inspector/patch across multiple package.json files to newer alpha versions, ensuring the use of the latest features and fixes from the GraphQL Inspector library.
  • Schema Definition Refinement: Removed the schemaTypeName field from DirectiveUsageSchemaAdded and DirectiveUsageSchemaRemoved GraphQL types and their corresponding Zod models, simplifying the schema change data structure.
  • Directive Diff Rendering: Implemented logic to render directive differences directly on root schema definitions within the schema diffing component, providing more comprehensive change visualization.
  • Changelog Entry: Added a new changeset file to document the feature of rendering directive diffs on schema definitions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7552.hive-storybook.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/apollo 0.47.2-alpha-20260126175606-84de5d223e3dd1d5f42b8b442215cceadead1007 npm ↗︎ unpkg ↗︎
@graphql-hive/cli 0.57.4-alpha-20260126175606-84de5d223e3dd1d5f42b8b442215cceadead1007 npm ↗︎ unpkg ↗︎
@graphql-hive/core 0.20.2-alpha-20260126175606-84de5d223e3dd1d5f42b8b442215cceadead1007 npm ↗︎ unpkg ↗︎
@graphql-hive/envelop 0.40.4-alpha-20260126175606-84de5d223e3dd1d5f42b8b442215cceadead1007 npm ↗︎ unpkg ↗︎
@graphql-hive/yoga 0.47.2-alpha-20260126175606-84de5d223e3dd1d5f42b8b442215cceadead1007 npm ↗︎ unpkg ↗︎
hive 9.2.0-alpha-20260126175606-84de5d223e3dd1d5f42b8b442215cceadead1007 npm ↗︎ unpkg ↗︎

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates @graphql-inspector dependencies to an alpha version to support rendering directive diffs on schema definitions. The implementation correctly adds directive diffing for the root schema, but uses an incorrect path for schema-level directives. Additionally, several GraphQL types and Zod models are cleaned up by removing an unused schemaTypeName field. While the use of alpha dependencies is necessary for the new functionality, it introduces a potential stability risk that should be mitigated by upgrading to a stable release when available.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 84de5d223e3dd1d5f42b8b442215cceadead1007

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

💻 Website Preview

The latest changes are available as preview in: https://pr-7552.hive-landing-page.pages.dev

@jdolle jdolle merged commit 3f1743c into main Jan 27, 2026
27 checks passed
@jdolle jdolle deleted the directive-usage-schema branch January 27, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants