-
Notifications
You must be signed in to change notification settings - Fork 125
Enhancement: New lab docs #7560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @mskorokhodov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on introducing extensive documentation for the newly integrated "Hive Laboratory" feature. The new documentation provides detailed guides on core functionalities such as managing GraphQL operations, leveraging schema support, organizing with collections, utilizing preflight scripts for advanced request manipulation, handling environment variables, and reviewing execution history. Additionally, a minor but important UI adjustment was made to ensure the preflight prompt modal displays reliably. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7560.hive-storybook.pages.dev |
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/cli |
0.57.2-alpha-20260126123418-6abbfd2d37691f1f8b41d716322e2278629385bc |
npm ↗︎ unpkg ↗︎ |
hive |
9.0.0-alpha-20260126123418-6abbfd2d37691f1f8b41d716322e2278629385bc |
npm ↗︎ unpkg ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces comprehensive documentation for the new laboratory feature, covering collections, environment variables, history, operations, and preflight scripts. While the documentation is well-structured and helpful, a critical security vulnerability has been identified: the documented claim of 'No network access' for preflight scripts is not enforced in the actual implementation of the script sandbox. This creates a risk of data exfiltration if malicious scripts are executed. It is crucial to enforce actual network isolation and update the documentation to accurately reflect the security posture. Additionally, a setTimeout was introduced in laboratory.tsx before opening a modal, which should be reviewed for a more robust solution.
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7560.hive-landing-page.pages.dev |
n1ru4l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Background
Description
Checklist