-
Notifications
You must be signed in to change notification settings - Fork 125
Fix references in CDN Modal and Apollo Router integration docs #7583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ardatan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses inconsistencies in the documentation by updating references to gateway technologies. It specifically ensures that 'Apollo Router' is correctly used where 'Hive Gateway' or 'Apollo Gateway' were previously mentioned, improving accuracy and clarity for users integrating with the Apollo Router. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/apollo |
0.47.2-alpha-20260127080551-687c0df2c0cdd004877b84440085178c08807cb8 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/cli |
0.57.4-alpha-20260127080551-687c0df2c0cdd004877b84440085178c08807cb8 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/core |
0.20.2-alpha-20260127080551-687c0df2c0cdd004877b84440085178c08807cb8 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/envelop |
0.40.4-alpha-20260127080551-687c0df2c0cdd004877b84440085178c08807cb8 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/yoga |
0.47.2-alpha-20260127080551-687c0df2c0cdd004877b84440085178c08807cb8 |
npm ↗︎ unpkg ↗︎ |
hive |
9.2.0-alpha-20260127080551-687c0df2c0cdd004877b84440085178c08807cb8 |
npm ↗︎ unpkg ↗︎ |
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7583.hive-storybook.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes references to Apollo Gateway in the CDN Modal and Apollo Router integration documentation, replacing them with Apollo Router. The changes align with the PR's stated goal. I found one issue where the example docker command for Apollo Router in the CDN modal is missing a port mapping, which would prevent users from accessing the router. I've suggested a fix to add the port mapping to make it consistent with other examples and the documentation.
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7583.hive-landing-page.pages.dev |
Hive Gatewaybut it should beApollo RouterApollo Gatewaybut it should beApollo Router