Skip to content

Conversation

@DavidLambauer
Copy link
Contributor

@DavidLambauer DavidLambauer commented Oct 1, 2025

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

Current behavior

Fixes: #2821

New behavior

Created comprehensive documentation covering all required areas:

New documentation:

  • libs/contact/guides/state.md - Complete state management guide

    • Documents DaffContactStateModule and DaffContactFacade
    • All 6 actions with examples (Submit, Success, Failure, Retry, Cancel, Reset)
    • All 3 selectors (success, error, loading)
    • Full working component example with template
  • libs/contact/guides/testing.md - Testing utilities guide

    • Documents DaffContactStateTestingModule and MockDaffContactFacade
    • Complete test examples with jasmine-marbles
    • Shows how to test action dispatch and observable streams

Updated documentation:

  • libs/contact/README.md

    • Added guides navigation table
    • Fixed outdated action names (DaffContactSubscribe → DaffContactSubmit)
    • Fixed incorrect imports (removed non-existent DaffContactSubmission)
    • Updated all code examples to use current API
    • Added reference to state guide for detailed info
  • libs/contact/guides/drivers.md

    • Fixed import typo (@daffodil/Contact/testing → @daffodil/contact/driver/in-memory)
    • Fixed Hubspot config import (@daffodil/driver/hubspot)
    • Removed broken "advanced setup guide" links

All 8 requirements from issue are now satisfied:
✓ Package overview
✓ Installation instructions
✓ Usage guidelines
✓ Contact form submission process
✓ State management
✓ Driver details (Hubspot)
✓ Configuration instructions
✓ Testing procedures

Breaking change?

  • Yes
  • No

Additional context

…documentation

Created comprehensive documentation covering all required areas:

New documentation:
- libs/contact/guides/state.md - Complete state management guide
  * Documents DaffContactStateModule and DaffContactFacade
  * All 6 actions with examples (Submit, Success, Failure, Retry, Cancel, Reset)
  * All 3 selectors (success, error, loading)
  * Full working component example with template

- libs/contact/guides/testing.md - Testing utilities guide
  * Documents DaffContactStateTestingModule and MockDaffContactFacade
  * Complete test examples with jasmine-marbles
  * Shows how to test action dispatch and observable streams

Updated documentation:
- libs/contact/README.md
  * Added guides navigation table
  * Fixed outdated action names (DaffContactSubscribe → DaffContactSubmit)
  * Fixed incorrect imports (removed non-existent DaffContactSubmission)
  * Updated all code examples to use current API
  * Added reference to state guide for detailed info

- libs/contact/guides/drivers.md
  * Fixed import typo (@daffodil/Contact/testing → @daffodil/contact/driver/in-memory)
  * Fixed Hubspot config import (@daffodil/driver/hubspot)
  * Removed broken "advanced setup guide" links

All 8 requirements from issue graycoreio#2821 are now satisfied:
✓ Package overview
✓ Installation instructions
✓ Usage guidelines
✓ Contact form submission process
✓ State management
✓ Driver details (Hubspot)
✓ Configuration instructions
✓ Testing procedures

Closes graycoreio#2821
@DavidLambauer DavidLambauer requested a review from a team as a code owner October 1, 2025 15:16
@xelaint xelaint changed the title docs(contact): close #2821 - standardize @daffodil/contact documentation docs(contact): standardize @daffodil/contact documentation Oct 1, 2025
@xelaint xelaint added the package: contact @daffodil/contact label Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: contact @daffodil/contact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] @daffodil/contact Standardized Documentation

2 participants