feat(builders,daffio): generate sitemap #4152
Conversation
| @@ -0,0 +1,2 @@ | |||
| Sitemap: https://next.daff.io/sitemapindex.xml | |||
There was a problem hiding this comment.
Extract the robots.txt out to another PR
There was a problem hiding this comment.
done, coming after this is merged
| resolve, | ||
| join, | ||
| } from 'node:path'; | ||
| import { create } from 'xmlbuilder2'; |
There was a problem hiding this comment.
I was looking at the depgraph of xmlbuilder2. It looks like it has a few more deps. It also appears slower than https://github.com/NaturalIntelligence/fast-xml-parser/ according to their benchmarks (I had to run these manually).
Do you think we should write to use fast-xml-parser? I don't know if you already evaluated this.
There was a problem hiding this comment.
I haven't. Given that this is a dev only dep, I didn't put that much thought into it.
| const sitemap = options.sitemaps[name]; | ||
| if ('prerenderedRoutes' in sitemap) { | ||
| try { | ||
| const routes = Object.keys(JSON.parse(await readFile(join(PROJECT_ROOT, <string>sitemap.prerenderedRoutes), 'utf-8')).routes); |
There was a problem hiding this comment.
Write a test for this builder.
griest024
force-pushed
the
feat/dgeni/sitemap
branch
from
ab4dcb8 to
a47a1e5
Compare
griest024
force-pushed
the
feat/dgeni/sitemap
branch
from
7c75fea to
956686e
Compare
|
@damienwebdev this needs a re-review |
|
@damienwebdev bump |
2 participants
PR Checklist
PR Type
Current behavior
Fixes: #4094
Part of: #
New behavior
Breaking change?
Additional context