Bright Objects plot #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 27, 2021 10:34
Add sepList to get separation between GRB position and positions of catalog, saved in the report file
Renamed the previous method and changed code style
Method checks catalog of SGRs and calculates the separation to GRB position. Results are saved in _build_report.
Schönheitskorrektur
Implementing separation_values in report
Make separation tables shorter, only the three nearest
Function based on the existing location plot for a location plot of bright sources + SGRs
Fixes wrong location in plot and better visuals with markers
BjoernBiltzinger
suggested changes
Jan 25, 2022
morgoth/utils/plot_utils.py
Outdated
| if counter == 2: | ||
| dec_sgr = value | ||
| dec_center = dec_sgr * np.pi / 180 | ||
| ax.scatter(ra_center, dec_center, label=name, s=30, color="darkorange", |
Contributor
There was a problem hiding this comment.
write this as:
for m, (name, dictionary) in enumerate(SGRs.items()):
ra = np.deg2rad(dictionary["ra"])
dec = np.deg2rad(dictionary["dec"])
if ra>np.pi:
ra-=2*np.pi
ax.scatter(ra, dec, label=name, s=30, color="darkorange",marker=markers[m])
Same for the bright sources in line 440
| "dec":round(table[i]['Coords Degs'].dec.degree,3), | ||
| "separation":table[i]["Separation Degs"]} | ||
|
|
||
| self._dic_SGRs = dic |
Contributor
There was a problem hiding this comment.
change this to
dic = {}
for i in range(3):
dic[str(table[i]['Name'])]={"ra":float(round(table[i]['Coords Degs'].ra.degree,3)),
"dec":float(round(table[i]['Coords Degs'].dec.degree,3)),
"separation":float(table[i]["Separation Degs"])}
self._dic_SGRs = dic
Same for bright sources. Otherwise the numbers were saved as some strange type in the yaml and could not be read later. I changed this when we added the table on the website, but let's add it here to make it consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function based on the existing location plot for a location plot of bright sources + SGRs