Skip to content

Conversation

@tmsanrinsha
Copy link

I want to use -S option with space, e.g. -S'foo bar'.
But the string is escaped and become -S\'foo bar'\'''.
Shellescape is really needed?

@gregsexton
Copy link
Owner

It's been a long time since I wrote this. I remember testing various cases on Windows and different nix shells. I can only say that I put this in for a good reason. @AlterDepp, this is up to you. I would probably look for a better solution rather than just taking it out.

@rbong
Copy link
Collaborator

rbong commented Dec 17, 2016

I've added s:Gitv_DisableShellEscape as an option. Obviously, this is not a long term solution, but until I can test on other shells hopefully it will save some headaches. I may very well revert my changes and merge this when I can test. I am leaving this open intentionally.

@rbong rbong added this to the 1.4.2 milestone Apr 14, 2017
@rbong rbong force-pushed the master branch 2 times, most recently from 1b29a2f to 467d6c7 Compare April 14, 2017 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants