Skip to content

Conversation

@gregtatcam
Copy link
Owner

High Level Overview of Change

Update TickSize logic for MPT offers as follows:

  • XRP/MPT, MPT/XRP, MPT/MPT offers are not adjusted for TickSize
  • IOU/MPT, MPT/IOU have TickSize logic applied to adjust IOU only
  • IOU/IOU, XPR/IOU, IOU/XRP offers have TickSize logic unchanged

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Test Plan

Extended OfferMPT unit-tests.

int val2;
};
// XRP/MPT, MPT/XRP, MPT/MPT offers are not adjusted for TickSize
// IOU/IOU, XPR/IOU, IOU/XRP offers have TickSize logic unchanged

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// IOU/IOU, XPR/IOU, IOU/XRP offers have TickSize logic unchanged
// IOU/IOU, XRP/IOU, IOU/XRP offers have TickSize logic unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants