Skip to content

Port added even if not necessary (http:80 / https:443) #98 #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smalot wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Port added even if not necessary (http:80 / https:443) #98 #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33dd408
Update cycle.js
smalot Aug 2, 2017
23cb7dc
Clean any instance of _getDefaultPort() function
Aug 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cycle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ export default class Cycle extends EventEmitter {
protocol: req.protocol,
proxy: upstreamProxy,
hostname: req.hostname,
port: req.port || req._getDefaultPort(),
port: req.port,
method: req.method,
path: req.url,
headers: req.headers,
Expand Down
9 changes: 1 addition & 8 deletions src/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,20 +195,13 @@ export default class Request extends Body {
if (port){
this.port = port
}
//this.port = purl.port || host.port || this._getDefaultPort()
//this.port = purl.port || host.port
this.method = inReq.method
this.url = purl.path
inReq._isOriginal = true
this._source = inReq
}

/**
* Returns the default port given the current protocol.
*/
_getDefaultPort(){
return this.protocol === 'https:' ? 443 : 80
}

// TODO: emit debug log events for things that are changed.
_finalize(){
if (nonEntityMethods.hasOwnProperty(this.method)) {
Expand Down