chao: ensure volumeMounts key present when tls identity supplied#138
Merged
philgebhardt merged 1 commit intomasterfrom Feb 10, 2026
Merged
chao: ensure volumeMounts key present when tls identity supplied#138philgebhardt merged 1 commit intomasterfrom
philgebhardt merged 1 commit intomasterfrom
Conversation
philgebhardt
force-pushed
the
EN-9400/volume-mounts
branch
from
d930f66 to
4a240af
Compare
without this, it's possible to get an invalid yaml document when `ssl.certDir` is not supplied, but values under `chao.tls.identity` are supplied. It's not yet clear to me why the unit tests don't catch this.
philgebhardt
force-pushed
the
EN-9400/volume-mounts
branch
from
4a240af to
19bd8d9
Compare
sirged
approved these changes
Feb 10, 2026
thefirstofthe300
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without this, it's possible to get an invalid yaml document when
ssl.certDiris not supplied, but values underchao.tls.identityare supplied.It's not yet clear to me why the unit tests don't catch this.The problem with the existing unit tests is they relied on default values for defining gremlin auth
gremlin.secret. I've split relevant test suites into new ones that run a bunch of tests using cert auth and secret auth, which catches the bug without the fix.