Added get started button to home page #548
Conversation
dafuga
changed the title
| return hasWebAuth; | ||
| } | ||
| $effect(() => { |
There was a problem hiding this comment.
onMount ?
Why wouldn't it be available?
There was a problem hiding this comment.
I confirmed that it takes a second for it to become available, but I got it working without the polling.
Deploying unicove-jungle4 with
|
| Latest commit: |
b2f31b1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4ba1291c.unicove-jungle4.pages.dev |
| Branch Preview URL: | https://adding-getting-started-butto.unicove-jungle4.pages.dev |
dafuga
force-pushed
the
adding-getting-started-button
branch
from
e15eb8a to
5a7cdb8
Compare
| <div class="grid gap-4"> | ||
| <!-- <div class="grid gap-4 @2xl:grid-cols-2"> --> | ||
| <!-- <Button variant="primary">Create your Vaulta account</Button> --> | ||
| <Button |
There was a problem hiding this comment.
I'm assuming that it's fine to remove this button at this point.
dafuga
force-pushed
the
adding-getting-started-button
branch
from
5a7cdb8 to
334fc76
Compare
dafuga
force-pushed
the
adding-getting-started-button
branch
from
334fc76 to
dec0f8b
Compare
dafuga
force-pushed
the
adding-getting-started-button
branch
from
03e2eb8 to
f204691
Compare
dafuga
force-pushed
the
adding-getting-started-button
branch
from
86972e8 to
b31e3c3
Compare
| > | ||
| <span class="">Unicove -</span> | ||
| The {networkName} web wallet and block explorer. | ||
| Unicove Your Gateway To The Vaulta Network. |
There was a problem hiding this comment.
I'm thinking there should be some punctuation after "Unicove"
Either: "Unicove: Your gateway to the Vaulta network"
Or: "Unicove. Your gateway to the Vaulta network"
There was a problem hiding this comment.
Also, would hardcoding "Vaulta" be a problem for Telos/Wax/etc.?
There was a problem hiding this comment.
This is in the vaulta() snippet so it won't affect what is displayed for Telos or WAX.
There was a problem hiding this comment.
And sounds good, I'll just remove the word Univove for now 👍
|
|
||
| {#if pluginAvailable} | ||
| <Button variant="primary" class="w-fit" onclick={handleGetStarted} | ||
| >Get Started - Create Account</Button |
There was a problem hiding this comment.
This button label has two actions: "Get started" and "Create account". Maybe we choose one or the other?
Or combine them? "Get started with an account"
|
Otherwise, it looks good to me |
|
Except for mobile: the vertical spacing is now broken |
|
Good catch 👍 |
|
I always forget to check what things look like on mobile 😂 |
|
@deansallinen Fixed 👍 |
No description provided.