Open
Conversation
sitemap indexing google news sitemap support based on requirements via support.google.com creating a Google News Sitemap sitemaps file added added tests for sitemaps cleaned up code
django_mesh_test_project/urls.py
Outdated
Member
|
The test for this is failing with this assertion error: I'd check to see what the actual output is, it might use the full XML namespace instead of the alias you're using in your assertion. |
Member
There was a problem hiding this comment.
It would be good to add assertions for the values these tags contain.
It might be helpful to use an XML parser. This is a good one:
https://pypi.python.org/pypi/xmltodict
SeanHayes
force-pushed
the
master
branch
2 times, most recently
from
14805c1 to
e3311ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sitemaps with an index sitemap and sub-sitemaps pointing to public published channels, posts, and tags. Things requiring a user to follow will not show up. I still have to figure out how to and what to test with this branch, but it does create a sitemap that complies with Google News Sitemap's requirements.