Extract some code to new lib actions #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
thangqp
reviewed
Feb 10, 2026
src/test/java/org/gridsuite/actions/server/ContingencyListControllerTest.java
Outdated
Show resolved
Hide resolved
thangqp
reviewed
Feb 10, 2026
src/main/java/org/gridsuite/actions/server/service/FilterService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
thangqp
reviewed
Feb 11, 2026
| public class ActionsConfig { | ||
| @Bean | ||
| public ContingencyListEvaluator contingencyListEvaluator( | ||
| FilterProviderI filterProvider |
There was a problem hiding this comment.
Suggested change
| FilterProviderI filterProvider | |
| FilterProvider filterProvider |
According to the name updating in actions lib
thangqp
reviewed
Feb 11, 2026
| import java.util.UUID; | ||
|
|
||
| @Service | ||
| public class FilterProviderImpl implements FilterProviderI { |
There was a problem hiding this comment.
Suggested change
| public class FilterProviderImpl implements FilterProviderI { | |
| public class DefaultFilterProvider implements FilterProvider { |
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
thangqp
reviewed
Feb 11, 2026
src/main/java/org/gridsuite/actions/server/service/DefaultFilterProvider.java
Show resolved
Hide resolved
src/main/java/org/gridsuite/actions/server/service/DefaultFilterProvider.java
Show resolved
Hide resolved
| import java.util.UUID; | ||
|
|
||
| @Service | ||
| public class FilterProviderImpl implements FilterProvider { |
There was a problem hiding this comment.
Suggested change
| public class FilterProviderImpl implements FilterProvider { | |
| public class DefaultFilterProvider implements FilterProvider { |
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
thangqp
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary