fix: set proper message key in yup validation schemes#1019
Merged
TheMaskedTurtle merged 2 commits intomainfrom Feb 13, 2026
Merged
fix: set proper message key in yup validation schemes#1019TheMaskedTurtle merged 2 commits intomainfrom
TheMaskedTurtle merged 2 commits intomainfrom
Conversation
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
dbraquart
reviewed
Feb 12, 2026
Contributor
dbraquart
left a comment
dbraquart
left a comment
There was a problem hiding this comment.
code: ok - just 2 open questions
tests: ok study + explore
src/components/network-modifications/substation/creation/substationCreation.utils.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
|
dbraquart
approved these changes
Feb 12, 2026
TheMaskedTurtle
deleted the
jorism/fix/yup-errors-translations-in-network-modifs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This puts the light on a widespread issue yupConfig in commons-ui is not properly taken into account.
Here we fix it only for network-modifications (new forms) but at some points we would have to fix it for other forms.