Merged
Conversation
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
…ting sets by name in groups Signed-off-by: Thang PHAM <phamthang37@gmail.com>
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
thangqp
commented
Dec 1, 2025
| ], | ||
| "setsGroups": [ | ||
| { | ||
| "name": "IEEE14_TCB_1", |
Contributor
Author
There was a problem hiding this comment.
Naming with prefix IEEE14 for TCB is the demand of @gautierbureau
thangqp
commented
Dec 1, 2025
| "family": "VOLTAGE", | ||
| "model": "TapChangerBlockingAutomaton", | ||
| "setGroup": "TCB_2_4", | ||
| "setGroup": "IEEE14_TCB_1", |
Contributor
Author
There was a problem hiding this comment.
Adapt to the naming with prefix IEEE14 for TBC (demanded by @gautierbureau )
etiennehomer
reviewed
Dec 4, 2025
src/main/resources/db/changelog/changesets/changelog_20251120T230357Z.xml
Outdated
Show resolved
Hide resolved
src/main/resources/db/changelog/changesets/changelog_20251120T230357Z.xml
Show resolved
Hide resolved
src/main/java/org/gridsuite/mapping/server/service/implementation/ModelServiceImpl.java
Show resolved
Hide resolved
src/main/java/org/gridsuite/mapping/server/service/implementation/ModelServiceImpl.java
Show resolved
Hide resolved
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
This was referenced Dec 8, 2025
etiennehomer
previously approved these changes
Dec 9, 2025
etiennehomer
reviewed
Dec 9, 2025
src/main/java/org/gridsuite/mapping/server/model/ModelParameterEntity.java
Outdated
Show resolved
Hide resolved
| @Table(name = "model_parameter", indexes = {@Index(name = "model_parameter_name_index", columnList = "name")}) | ||
| public class ModelParameterEntity implements Serializable { | ||
|
|
||
| @EqualsAndHashCode.Include |
Contributor
Author
There was a problem hiding this comment.
NO, see the above explaination.
etiennehomer
reviewed
Dec 9, 2025
src/main/java/org/gridsuite/mapping/server/model/ModelSetsGroupEntity.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
…facto_entities' into rework_on_model_by_using_uuid_refacto_entities
|
etiennehomer
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Using uuid (instead of name) as primary key for all model-related entities
What did in this PR:
For entities which define instants (
Model,ModelSetsGroupEntity,ModelParameterSetEntity,ModelParameterEntity), we remove all id classes, i.e.ModelParameterId,ModelParameterSetId,ModelSetsGroupIdwhich contain duplicated infos, and replace byidwith type UUIDFor entities which define definitions (
ModelParameterDefinitionEntity,ModelVariableDefinitionEntity,ModelVariableSetEntity), we addidfield beside the exisitingnamefield.All relations are now modelized through ids but we keep
namefor all entities.Add
idfields for corresponding dtos to round-tripidfor update actionsAdapt existing implementation in
ModelServiceImplfor importing correctly model in json format in taking into account the reuse of parameter definitions, and variable definitions.Add models in json format and bash script into
/resourceto bootstrap initial modelsRelated PR front : gridsuite/griddyna-app#164