Skip to content

Avoid hangout when exception in async test #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thangqp merged 1 commit into from
Jan 20, 2026
Merged

Avoid hangout when exception in async test #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/test/java/org/gridsuite/ds/server/controller/DynamicSimulationControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,8 +448,12 @@ private UUID runAndCancel(CountDownLatch cancelLatch, int cancelDelay) throws Ex

assertRunningStatus(runUuid);

// stop dynamic simulation
cancelLatch.await();
// stop dynamic simulation, need a timeout to avoid test hangs if an exception occurs before latch countdown
boolean completed = cancelLatch.await(5, TimeUnit.SECONDS);
if (!completed) {
throw new AssertionError("Timed out waiting for cancelLatch, something might have crashed before latch countdown happens.");
}

// custom additional wait
await().pollDelay(cancelDelay, TimeUnit.MILLISECONDS).until(() -> true);

Expand Down