More explicit endpoint access control API#101
Open
Tristan-WorkGH wants to merge 3 commits intomainfrom
Open
Conversation
it's caracterized by `EndPointElementServer` interface
If a pattern is to be used multiple times, compiling it once and reusing it will be more efficient than invoking this method each time.
Tristan-WorkGH
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we look that the
hasElementsAccessControl()is alwaysfalsewith implementations ofEndPointServer, and alwaystruewith the override ofEndPointElementServer.When analysing
ElementAccessControllerGlobalPreFilter, it is in fact considering that if there is elements access control, then it is anEndPointElementServer(cast object).This PR:
hasElementsAccessControl()fromEndPointServerEndPointElementServertoEndPointAccessControlledServerto be more explicit of what the interface permit