Typescript migration for Equipment Deletion #3671
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbraquart
changed the title
dbraquart
force-pushed
the
dbraquart/ts-migration-for-equipment-deletion
branch
2 times, most recently
from
bcef41a to
285825c
Compare
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
dbraquart
force-pushed
the
dbraquart/ts-migration-for-equipment-deletion
branch
from
6fff61d to
d8c0623
Compare
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
dbraquart
force-pushed
the
dbraquart/ts-migration-for-equipment-deletion
branch
from
a2e2bad to
365970f
Compare
…n-for-equipment-deletion # Conflicts: # src/components/dialogs/network-modifications/equipment-deletion/equipment-deletion-form.tsx # src/components/graph/menus/network-modifications/network-modification-node-editor.tsx # src/services/study/network-modifications.ts
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
achour94
reviewed
Feb 11, 2026
|
|
||
| const emptyFormData: EquipmentDeletionFormInfos = { | ||
| [EQUIPMENT_ID]: '', | ||
| [TYPE]: EquipmentType.SUBSTATION, |
Contributor
There was a problem hiding this comment.
I think that this is causing double fetch of equipment ids wen we open the dialog and equipment type is different than Substation
Contributor
Author
There was a problem hiding this comment.
yes I can see the double fetch. good catch!
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
JS -> TS
Includes both generic deletion and HVDC-LCC specific deletion